build: fix arm64 cross-compilation#51256
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Dec 27, 2023
Merged
Conversation
Commit 938212f added -msign-return-address=all to _all_ cflags but that is wrong when cross-compiling, it should only be added to the target's cflags. The flag being deprecated, it is also changed to `-mbranch-protection=standard`. Fixes: nodejs#42888 Co-Authored-By: Michaël Zasso <targos@protonmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Collaborator
richardlau
approved these changes
Dec 22, 2023
lpinca
approved these changes
Dec 22, 2023
Collaborator
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in c21b2be |
This was referenced Dec 28, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
Commit 938212f added -msign-return-address=all to _all_ cflags but that is wrong when cross-compiling, it should only be added to the target's cflags. The flag being deprecated, it is also changed to `-mbranch-protection=standard`. Fixes: #42888 Co-Authored-By: Michaël Zasso <targos@protonmail.com> PR-URL: #51256 Fixes: nodejs/build#3319 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
robertsLando
added a commit
to yao-pkg/pkg-fetch
that referenced
this pull request
Jan 3, 2024
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Commit 938212f added -msign-return-address=all to _all_ cflags but that is wrong when cross-compiling, it should only be added to the target's cflags. The flag being deprecated, it is also changed to `-mbranch-protection=standard`. Fixes: #42888 Co-Authored-By: Michaël Zasso <targos@protonmail.com> PR-URL: #51256 Fixes: nodejs/build#3319 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
I've tried cross compiling node 21.7.2, which has this patch, on x86_64 targetting aarch64. The build fails: If I remove the |
Member
This means you are using a compiler earlier than gcc 9 -- |
|
Hi @richardlau, thanks for looking at this.
I thought this too, but I double-checked and I'd built GCC13. It seems like the build is trying to use the host gcc (it's passing |
Member
|
Do you have |
|
Hi @richardlau, I was using: |
Member
Contributor
|
I was able to cross-compile for ARM64 on my x64 machine with #52559. Here are the commands I used: # Setting up the env
export CC_host="gcc"
export CXX_host="g++"
export CC="aarch64-linux-gnu-gcc"
export CXX="aarch64-linux-gnu-g++"
export AS="aarch64-linux-gnu-as"
export LD="aarch64-linux-gnu-ld"
export RANLIB="aarch64-linux-gnu-ranlib"
# Building as a shared library also works with --shared
./configure --dest-cpu arm64 --dest-os linux
# Build it
make -j12 |
|
Thanks a lot @richardlau and @devraymondsh, I got a successful cross-compilation with those patches too. |
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
Commit 938212f added -msign-return-address=all to _all_ cflags but that is wrong when cross-compiling, it should only be added to the target's cflags. The flag being deprecated, it is also changed to `-mbranch-protection=standard`. Fixes: #42888 Co-Authored-By: Michaël Zasso <targos@protonmail.com> PR-URL: #51256 Fixes: nodejs/build#3319 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #45756 (@bnoordhuis)
Commit 938212f added -msign-return-address=all to all cflags but that
is wrong when cross-compiling, it should only be added to the target's
cflags.
The flag being deprecated, it is also changed to
-mbranch-protection=standard.Fixes: #42888
Fixes: nodejs/build#3319